-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage Private Email Addresses #1319
Conversation
# Conflicts: # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# Conflicts: # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@afterxleep generally looking good! There is one flow isn't behaving quite correctly though:
|
@amddg44 These messages have changed like 200 times. I've updated the screenshots with the latest version. |
@amddg44 I've updated the prompt logic to cover the ycombinator scenario. I was not including empty username accounts as part of the logic. Should be fixed in the BSK via this commit |
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/SecureVault/View/PasswordManagementLoginItemView.swift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Really nice work @afterxleep!
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/Autofill/ContentOverlayViewController.swift # DuckDuckGo/Common/Localizables/UserText.swift # DuckDuckGo/Menus/MainMenuActions.swift # DuckDuckGo/Tab/TabExtensions/AutofillTabExtension.swift
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Task/Issue URL: https://app.asana.com/0/72649045549333/1204615490114675/f iOS PR: duckduckgo/iOS#1828 macOS PR: duckduckgo/macos-browser#1319 What kind of version bump will this require?: Minor Description: Allows users to manage their Private Email addresses from the browser.
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # LocalPackages/NetworkProtectionUI/Package.swift
Task/Issue URL: https://app.asana.com/0/72649045549333/1204615490114675/f
BSK PR: duckduckgo/BrowserServicesKit#396
Description:
Steps to test this PR:
Address Management
Partial account updating
Partial account updating (Various updates)
Credentials save prompt
Credentials update prompt
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation